ext/pcntl: Fix signal table updated before php_signal4 succeeds in pc…#21270
Closed
devnexen wants to merge 2 commits intophp:PHP-8.4from
Closed
ext/pcntl: Fix signal table updated before php_signal4 succeeds in pc…#21270devnexen wants to merge 2 commits intophp:PHP-8.4from
devnexen wants to merge 2 commits intophp:PHP-8.4from
Conversation
arnaud-lb
approved these changes
Feb 23, 2026
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
This looks good to me.
I was wondering whether this introduced a race condition when a signal is delivered before the zend_hash_index_update(), but I think it doesn't since the handler doesn't touch &PCNTL_G(php_signal_table).
ext/pcntl/pcntl.c
Outdated
| handle = zend_hash_index_update(&PCNTL_G(php_signal_table), signo, handle); | ||
| Z_TRY_ADDREF_P(handle); | ||
|
|
||
| /* we need to register in the OS side first before we update the internal list */ |
Member
There was a problem hiding this comment.
It could be worth it to specify why
…ntl_signal Move the signal table update after the php_signal4 call, mirroring what is already done in the SIG_DFL/SIG_IGN (integer) code path. This prevents a stale entry in the table if sigaction fails.
devnexen
force-pushed
the
pcntl_signal_fix
branch
from
4d4994f to
806813f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntl_signal
Move the signal table update after the php_signal4 call, mirroring what is already done in the SIG_DFL/SIG_IGN (integer) code path. This prevents a stale entry in the table if sigaction fails.